-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-8057 Inadequate information for handling catch clauses #362
Conversation
@@ -124,11 +124,11 @@ protected synchronized void cleanupRunningContainers() { | |||
} catch (YarnException e) { | |||
LOG.error("Failed to stop Container " + | |||
startedContainer.getContainerId() + | |||
"when stopping NMClientImpl"); | |||
"when stopping NMClientImpl", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what’s the e use for in log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no "e", the log here will only show the message "Failed to stop Container ### when stopping NMClientImpl". People will only know there's something wrong here, but will not know what's wrong here. (YarnException? IOException?)
If add an "e" here, the exception type and position where this exception happens will also be generated to the log, so that people will know what's wrong here.
Hey Iq you have been in my phone a lot and who ever you been on here with is hacking my phone so tell me what an WHY u messing with my phone |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
I do nothing for your phone, however I will also receive the apple id is binding by other person now . |
…stateful operators. Verified with a test standalone job. Will add integration test for this as a part of fixing and reenabling standalone integration tests. Author: Shanthoosh Venkataraman <svenkataraman@linkedin.com> Reviewers: Boris Shkolnik <boryas@apache.org> Closes apache#362 from shanthoosh/master
The description of the problem:
https://issues.apache.org/jira/browse/YARN-8057
I added stack traces information to those two logging statements, so that the full exception information can be generated to the logs.